Skip to content

fix: MUSD-772 fix earn deposits redirecting to activity view with no way to leave#29763

Merged
Matt561 merged 3 commits into
mainfrom
fix/musd-772-fix-earn-deposits-redirecting-to-activity-view-with-no-way-to-leave
May 6, 2026
Merged

fix: MUSD-772 fix earn deposits redirecting to activity view with no way to leave#29763
Matt561 merged 3 commits into
mainfrom
fix/musd-772-fix-earn-deposits-redirecting-to-activity-view-with-no-way-to-leave

Conversation

@Matt561
Copy link
Copy Markdown
Contributor

@Matt561 Matt561 commented May 5, 2026

Description

Fixes a regression introduced in #29454 where Earn redirects to the activity view for successful pooled-staking or lending deposits would leave users stranded without a way to exit.

This comes as part of a larger change to replace activity with Money in the main navbar.

Changelog

CHANGELOG entry: Fixes a regression where Earn redirects to the activity view for successful pooled-staking or lending deposits would leave users stranded without a way to exit.

Related issues

Fixes: MUSD-772: Fix deposit redirects for Earn flows leaving users stranded on Activity page

Manual testing steps

Feature: Activity screen navigation when Money Home is enabled

  Scenario: user accesses activity list from Money Home
    Given the Money Home feature flag is enabled
    And user is on the pooled-staking or lending deposit confirmation screen

    When confirms their transaction
    Then user is redirected to the activty with
    And a back button is displayed in the Activity screen header
    And user can navigate back to Wallet Home without being stranded

Screenshots/Recordings

Before

musd-772-fix-earn-redirects-to-activity-without-way-to-leave-demo-before.mov

After

musd-772-fix-earn-redirects-to-activity-without-way-to-leave-demo-after.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Changes back-navigation behavior (including Android hardware back handling) for ActivityView when the Money Home feature flag is enabled, which could affect user navigation flows if routing assumptions are wrong. Scope is limited and covered by new unit tests around back button and hardware back handling.

Overview
Fixes a regression where users redirected into ActivityView (e.g., after successful Earn deposits) could get stuck without a reliable way to exit when the Money Home experience is enabled.

When selectMoneyHomeScreenEnabledFlag is on, ActivityView now always shows a back button and routes both header back and Android hardwareBackPress to Routes.HOME_TABS (instead of returning to the prior stack/confirmation screen). The wallet’s Activity entrypoint no longer passes showBackButton params, and Routes adds a new HOME_TABS route constant.

Adds/updates ActivityView tests to cover Money-flag behavior for header back, hardware back interception, and header variant selection.

Reviewed by Cursor Bugbot for commit e5a0c60. Bugbot is set up for automated code reviews on this repo. Configure here.

Matt561 added 2 commits May 5, 2026 16:52
…eature is enabled; prevents users from stranded since the activity list is not part of the main action bar
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label May 5, 2026
@shane-t
Copy link
Copy Markdown
Member

shane-t commented May 6, 2026

Tested

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@Matt561 Matt561 added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 43a99ef May 6, 2026
101 of 102 checks passed
@Matt561 Matt561 deleted the fix/musd-772-fix-earn-deposits-redirecting-to-activity-view-with-no-way-to-leave branch May 6, 2026 16:17
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-M team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants